Fix binstubs path in webpacker:check_binstubs rake task #990
Conversation
* Also remove redundant check in tasks list
|
I'm not able to reproduce the failure you describe. I just created a new rails app with webpacker and ran The install task installs the binstubs here: webpacker/lib/install/template.rb Line 17 in 05bf821 Could you provide more info about the issue you're seeing and how to reproduce? |
Sorry, I have not provided important information. % mkdir rails_app && cd rails_app
% bundle init
Writing new Gemfile to /***/rails_app/Gemfile
% nano Gemfile
% cat Gemfile
# frozen_string_literal: true
source "https://rubygems.org"
git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
gem "rails"
% bundle install --path=vendor/bundle --binstubs=vendor/bundle/bin
(omit)
% rails new . --webpack=react
(omit)
run yarn add @rails/webpacker coffeescript@1.12.7 from "."
(omit)
Webpacker successfully installed 🎉 🍰
rails webpacker:install:react
Webpack binstubs not found.
Have you run rails webpacker:install ?
Make sure the bin directory or binstubs are not included in .gitignore
Exiting!
run bundle exec spring binstub --all
* bin/rake: spring inserted
* bin/rails: spring inserted
% rails webpacker:check_binstubs
Webpack binstubs not found.
Have you run rails webpacker:install ?
Make sure the bin directory or binstubs are not included in .gitignore
Exiting!Or, should not we change bundle bin path in rails app? |
|
Thanks @monad-y 👍 |
Fix
rails webpacker:check_binstubsrake task bug.In new rails project, this rake task fails even if
rails webpacker:installhas already executed.bin/webpack-dev-serverandbin/webpackis converted to binstubs by #833 .These files are not in
bin/directory but paths of them are remained around this repository yet.we might as well remove all paths.